Fix custom indexing for edge picks#256
Closed
MarkGillespie wants to merge 5 commits intonmwsharp:masterfrom
Closed
Fix custom indexing for edge picks#256MarkGillespie wants to merge 5 commits intonmwsharp:masterfrom
MarkGillespie wants to merge 5 commits intonmwsharp:masterfrom
Conversation
Owner
|
Thank you for this! I'm looking over this and I've totally forgotten how this logic works :) What is the change in behavior before-after this PR? Is the old code buggy/crashing? Or did it ignore custom indexing in the picking UI? |
Owner
|
Also for these size_t nCorners() const { return cornerDataSize == INVALID_IND ? nCornersCount : cornerDataSize; }We probably ought to create two separate functions size_t nCorners() const { nCornersCount; }
size_t cornerDataSize() const { return cornerDataSize == INVALID_IND ? nCornersCount : cornerDataSize; }otherwise the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update picking logic to use custom indices when picking edges and halfedges.
I'm not totally sure if I got all of the
recomputeIfPopulated();calls correct insurface_mesh.ipp: this code works for my use case, but it's possible that there are more arrays that should really be recomputed when the edge, halfedge, or corner permutations are set. Also, now the code callstriangleAllEdgeInds.recomputeIfPopulated();three times if the permutations are all set at once viaSurfaceMesh::setAllPermutationsis called.